Skip to content

Adopt generalized rich hover support for issues in the Issues View#1928

Merged
alexr00 merged 3 commits into
masterfrom
alexr00/issue#1905
Jun 29, 2020
Merged

Adopt generalized rich hover support for issues in the Issues View#1928
alexr00 merged 3 commits into
masterfrom
alexr00/issue#1905

Conversation

@alexr00

@alexr00 alexr00 commented Jun 22, 2020

Copy link
Copy Markdown
Member

Fixes #1905

@alexr00 alexr00 requested a review from RMacfarlane June 22, 2020 09:40
Comment thread src/typings/vscode.proposed.d.ts Outdated
@@ -0,0 +1,2104 @@
/*---------------------------------------------------------------------------------------------

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add this file, running yarn should pull the latest typings from master automatically. Is that not working?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, removed!

@RMacfarlane RMacfarlane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alexr00 alexr00 merged commit c94ce87 into master Jun 29, 2020
@alexr00 alexr00 deleted the alexr00/issue#1905 branch June 29, 2020 07:37
alexr00 added a commit that referenced this pull request Jul 9, 2020
…1928)

* Adopt generalized rich hover support for issues in the Issues View
Fixes #1905

* add proposed back to git ignore file

* Use resolveTreeItem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt generalized rich hover support for issues in the Issues View

2 participants