Diff: disable selecting line numbers - #1418
Merged
Rachel Macfarlane (RMacfarlane) merged 1 commit intoOct 28, 2019
Merged
Conversation
|
|
Rachel Macfarlane (RMacfarlane)
approved these changes
Oct 28, 2019
Rachel Macfarlane (RMacfarlane)
left a comment
Rachel Macfarlane (RMacfarlane)
left a comment
Contributor
There was a problem hiding this comment.
Very nice, thank you!
The DiffLine methods were stripped when data was passed from the extension to the webview, since JSON.stringify is used, so the typing is a bit wrong in that context. I think _raw is OK to use since that's the only way to get the data. Perhaps we can update the typings in the future
Mateusz Stopka (emtei)
deleted the
disable-selecting-line-numbers-in-diff
branch
October 28, 2019 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #354
This PR:
Splits line content into:
LineNumber,diffTypeSignandlineContentSets
user-select: none;for everything that is not a lineContentRemoves some duplicated code from
diff.tsxfileI'm not so proud of using private
_rawfield but i was unable to useDiffLinemethods.