Both Focus and Select tree item on triggering secondary action - #1388
Merged
Rachel Macfarlane (RMacfarlane) merged 2 commits intoOct 17, 2019
Conversation
Jackson Kearl (JacksonKearl)
requested a review
from Rachel Macfarlane (RMacfarlane)
October 17, 2019 03:38
Rachel Macfarlane (RMacfarlane)
suggested changes
Oct 17, 2019
Rachel Macfarlane (RMacfarlane)
left a comment
Rachel Macfarlane (RMacfarlane)
left a comment
Contributor
There was a problem hiding this comment.
Nice! I think there's one other place we need to update - the openDescription and openDescriptionToTheSide commands are only passing select: true to reveal
Contributor
Author
Rachel Macfarlane (RMacfarlane)
approved these changes
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1217
Previously, on triggering a secondary action, the tree view item would gain selected status, but not focused status. Additionally, previously, the 'openFile' command would move focus to the editor, hiding this issue when
git.openDiffOnClickwas true, and reducing keyboard accessibility (#198).This PR forces the selected item to also gain focus, and prohibits focus from transferring to editor on click.