Add lgtm integration - #1043
Merged
Merged
Conversation
Contributor
|
Question about the badge: if a security issue is detected by LGTM, will the badge immediately update? Follow-up question: is that, um, good? |
Contributor
Author
Ashi Krishnan (@queerviolet) yes. The idea is that the alert count can be checked before a new release is made.
Depends. The automated code review is better than this in that it will catch things in pull requests before they even reach master. We've also recently migrated to the LGTM.com GitHub App, so we are no longer using OAuth. |
Rachel Macfarlane (RMacfarlane)
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #948 getting merged, and github/codeql#920 being deployed to LGTM, there are now 0 alerts for this project on LGTM :).
It's probably a good idea to try and keep these alerts 0 or low. And there are a couple of ways that you could go about doing this:
READMEthat tracks how many LGTM alerts there are. This PR introduces that badge, though there aren't currently any other badges on theREADME, so I wasn't sure where the best place for it would be (this currently adds it under the Contributing header). (there's also a code quality badge if you care about that)Not sure which of these you'd prefer, but let me know if you have any questions. :)