feat: Support generate test methods in a test Java file#1173
Merged
Conversation
testforstephen
requested changes
Apr 20, 2021
Comment on lines
+205
to
+208
| final List<String> frameworkList = availableFrameworks.stream() | ||
| .sorted((kind1, kind2) -> kind1.getValueForRank() - kind2.getValueForRank()) | ||
| .map(framework -> framework.toString()) | ||
| .collect(Collectors.toList()); |
Contributor
There was a problem hiding this comment.
No need to reorder the available frameworks since you already preset the priority when you parse test framework from file or project.
Member
Author
There was a problem hiding this comment.
Since availableFrameworks is set, so I think we still need sort it?
Contributor
There was a problem hiding this comment.
When you find available frameworks, you already follow the order [junit5, junit4, testng] to search them. This is already the expected order you want.
testforstephen
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the first part of #1172 -- Add test method and lifecycle methods from a test source
UI entry
Source Actions>Generate Tests...Steps