chore: Use GitHub Actions for CI#1137
Merged
Merged
Conversation
jdneo
force-pushed
the
cs/jdneo-patch-1
branch
4 times, most recently
from
ed18557 to
108994f
Compare
jdneo
force-pushed
the
cs/jdneo-patch-1
branch
from
108994f to
455ee51
Compare
Comment on lines
+42
to
+43
| const methodEndIndex: number = fullName.indexOf('['); | ||
| const items: ILocation[] = await searchTestLocation(fullName.slice(fullName.indexOf('@') + 1, methodEndIndex < 0 ? undefined : methodEndIndex)); |
Contributor
There was a problem hiding this comment.
what's the purpose of this change?
Member
Author
There was a problem hiding this comment.
I should only provide the end param when the string has '[', otherwise indexOf('[') will return -1 thus the last character will be truncated.
It's a regression introduced in #1135. It will actually fail the CI, but since tracis.org is not working so I didn't find it in time.
Contributor
|
@majguo could you help review whether there is security vulnerability? |
majguo
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.