refactor: Leverage test finder for test discovery#1131
Merged
Conversation
Eskibear
reviewed
Jan 27, 2021
| final IJavaSearchScope scope = createSearchScope(params); | ||
| if (params.getLevel() == TestLevel.METHOD) { | ||
| // unreachable code since the client will directly run the test when it's triggered from method level | ||
| return Collections.emptyList(); |
Member
There was a problem hiding this comment.
if it's unreachable, maybe throw excepetion or do assertion? (when unexpected scenario does occur, it would be fast located..)
Eskibear
reviewed
Jan 27, 2021
| for (final IType type : types) { | ||
| final TestItem item = TestItemUtils.constructTestItem(type, TestLevel.CLASS, TestKind.JUnit5); | ||
| item.setChildren(Arrays.stream(type.getMethods()) | ||
| .map(m -> String.format("%s@%s", m.getJavaProject().getProject().getName(), |
Member
There was a problem hiding this comment.
String.format("%s@%s" is much slower. Because the pattern is simple, suggest to use string + "@" + string, which will be optimized by JVM to use StringBuilder under the hood.
Eskibear
reviewed
Jan 27, 2021
| for (final IType type : types) { | ||
| final TestItem item = TestItemUtils.constructTestItem(type, TestLevel.CLASS, TestKind.JUnit); | ||
| item.setChildren(Arrays.stream(type.getMethods()) | ||
| .map(m -> String.format("%s@%s", m.getJavaProject().getProject().getName(), |
Signed-off-by: Sheng Chen <sheche@microsoft.com>
Eskibear
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR leverage the upstream Test Finder for test discovery.
The previous implementation used
SearchEngine, since it's not good at handleing meta annotation, some bugs are introduced.fix #641
fix #773
fix #818