Skip to content

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Jan 5, 2024

See https://github.com/microsoft/vscode-java-dependency/actions/runs/7418895445/job/20187526152, the UI test doesn't run in the windows-UI CI job (0 passing). Updating the library vscode-extension-tester to the latest version 7.0.0 (which requires a minimum vscode@1.83.1) can fix it.

@testforstephen testforstephen requested review from CsCherrYY and jdneo and removed request for jdneo January 5, 2024 08:02
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jdneo jdneo added the eng engineering label Jan 5, 2024
@jdneo jdneo added this to the 0.23.4 milestone Jan 5, 2024
@jdneo jdneo merged commit a7df430 into main Jan 5, 2024
@jdneo jdneo deleted the jinbo_test branch January 5, 2024 08:10
JohnQNJ added a commit to JohnQNJ/vscode-java-dependency that referenced this pull request Dec 9, 2025
JohnQNJ added a commit to JohnQNJ/vscode-java-dependency that referenced this pull request Dec 9, 2025
JohnQNJ added a commit to JohnQNJ/vscode-java-dependency that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eng engineering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants