Repository navigation
fix: Show the hints in Java Projects explorer properly - #547
Merged
Merged
Conversation
Contributor
|
After testing, I find no regression but an existing bug about export jar. When there is no workspace and the language server has been activated, the export jar button doesn't show in the
I'd like to make the |
Sheng Chen (jdneo)
requested review from
Shi Chen (CsCherrYY),
Yan Zhang (Eskibear) and
Jinbo Wang (testforstephen)
September 15, 2021 02:11
Shi Chen (CsCherrYY)
previously approved these changes
Sep 15, 2021
Sheng Chen (jdneo)
changed the title
Sheng Chen (jdneo)
dismissed stale reviews from Yan Zhang (Eskibear) and Shi Chen (CsCherrYY)
via
September 16, 2021 06:41
3654d58
Shi Chen (CsCherrYY)
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is to let the Java Project explorer properly show hints for users:
redhat.javais not installed, hint for installationNow the activation events is the same as
redhat.java. But since events likeworkspaceContainsis not supported in when clause, so I use APIs to query files during activation and set context value to imitate the condition:resourceLangId == javais foronLanguage:javajava:workspaceContainsBuildFiles->workspaceContainsjava:serverModeis to make sure the explorer will always visible once JDT.LS is activated. (still visible when user switch focus to a non-Java file)fix #551