Skip to content

fix: export jar doesn't report error when grammatical error exists #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdneo merged 2 commits into from
Mar 9, 2021
Merged

fix: export jar doesn't report error when grammatical error exists #468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4187e2
accept error type
CsCherrYY Mar 8, 2021
d494c75
fix linting
CsCherrYY Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ async function handleBuildFailure(operationId: string, err: any): Promise<boolea
});
setErrorCode(error, Number(err));
sendOperationError(operationId, "build", error);
if (err === Jdtls.CompileWorkspaceStatus.Witherror || err === Jdtls.CompileWorkspaceStatus.Failed) {
// Workaround: Since VS Code 1.53, the contributed command would no longer throw exact error message when an error occurs.
// This change breaks the existing build error reporting, so we make a workaround here.
// Related issue: https://github.com/microsoft/vscode/issues/116932
if (err instanceof Error || err === Jdtls.CompileWorkspaceStatus.Witherror || err === Jdtls.CompileWorkspaceStatus.Failed) {
if (checkErrorsReportedByJavaExtension()) {
commands.executeCommand("workbench.actions.view.problems");
}
Expand Down