Skip to content

Fix uncaught exception for resolve classpath command #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jinbo Wang (testforstephen) merged 4 commits into from
Sep 27, 2017
Merged

Fix uncaught exception for resolve classpath command #64

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9a0a14
Fix uncaught exception for resolve classpath command
testforstephen Sep 27, 2017
fdb8c2f
Handle exception at the outer catch
testforstephen Sep 27, 2017
7685cd7
log exception to telemetry
testforstephen Sep 27, 2017
b6b7fcc
fix review comment
testforstephen Sep 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ import * as commands from "./commands";
const status: any = {};

export function activate(context: vscode.ExtensionContext) {
// The reporter will be initialized by the later telemetry handler.
let reporter: TelemetryReporter = null;

vscode.commands.registerCommand(commands.JAVA_START_DEBUGSESSION, async (config) => {

if (!status.debugging) {
Expand All @@ -19,7 +22,7 @@ export function activate(context: vscode.ExtensionContext) {
const level = await configLogLevel(vscode.workspace.getConfiguration().get("java.debug.logLevel"));
console.log("setting log level to ", level);
} catch (err) {
// log a warning message and contiue, since logger failure should not block debug session
// log a warning message and continue, since logger failure should not block debug session
console.log("Cannot set log level to java debuggeer.")
}
if (Object.keys(config).length === 0) { // No launch.json in current workspace.
Expand Down Expand Up @@ -63,7 +66,18 @@ export function activate(context: vscode.ExtensionContext) {
console.log("Cannot find a port for debugging session");
}
} catch (ex) {

const errorMessage = (ex && ex.message) || ex;
vscode.window.showErrorMessage(errorMessage);
if (reporter) {
const exception = (ex && ex.data && ex.data.cause)
|| { stackTrace: [], detailMessage: String((ex && ex.message) || ex || "Unknown exception") };
const properties = {};
properties.detailMessage = exception.detailMessage;
if (Array.isArray(exception.stackTrace)) {
properties.stackTrace = JSON.stringify(exception.stackTrace);
}
reporter.sendTelemetryEvent("exception", properties);
}
} finally {
delete status.debugging;
}
Expand All @@ -79,7 +93,7 @@ export function activate(context: vscode.ExtensionContext) {
aiKey: extensionPackage.aiKey,
};
if (packageInfo.aiKey) {
const reporter = new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey);
reporter = new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey);
reporter.sendTelemetryEvent("activateExtension", {});
const measureKeys = ["duration"];
vscode.debug.onDidTerminateDebugSession(() => {
Expand Down