Skip to content

update dependencies #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Eskibear merged 2 commits into from
Aug 20, 2019
Merged

update dependencies #633

Eskibear merged 2 commits into from
Aug 20, 2019

Conversation

@Eskibear
Copy link
Member

@Eskibear Eskibear commented Aug 20, 2019

dependencies updated via npm update. This can resolve potential vulnerabiliies.

Note:
I lock the vscode version, "@types/vscode": "1.32.0", which should be aligned with the engine.

@Eskibear
update dependencies
1b64995 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
fix tslint
7a8fda5 
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Member Author

Eskibear commented Aug 20, 2019

@testforstephen Just involved more changes by fixing below tslint issues.

ERROR: (no-console) /Users/sechs/Work/vscode-java-debug/src/configurationProvider.ts[250, 17]: Calls to 'console.log' are not allowed.
ERROR: (no-return-await) /Users/sechs/Work/vscode-java-debug/src/configurationProvider.ts[305, 28]: Unnecessary 'await'.
ERROR: (no-return-await) /Users/sechs/Work/vscode-java-debug/src/configurationProvider.ts[313, 20]: Unnecessary 'await'.
ERROR: (no-return-await) /Users/sechs/Work/vscode-java-debug/src/configurationProvider.ts[319, 20]: Unnecessary 'await'.
ERROR: (no-console) /Users/sechs/Work/vscode-java-debug/src/configurationProvider.ts[507, 13]: Calls to 'console.log' are not allowed.
ERROR: (no-console) /Users/sechs/Work/vscode-java-debug/src/configurationProvider.ts[511, 13]: Calls to 'console.log' are not allowed.
ERROR: (semicolon) /Users/sechs/Work/vscode-java-debug/src/configurationProvider.ts[511, 62]: Missing semicolon

ERROR: (semicolon) /Users/sechs/Work/vscode-java-debug/src/debugCodeLensProvider.ts[46, 90]: Missing semicolon

ERROR: (semicolon) /Users/sechs/Work/vscode-java-debug/src/extension.ts[10, 85]: Missing semicolon
ERROR: (semicolon) /Users/sechs/Work/vscode-java-debug/src/extension.ts[138, 97]: Missing semicolon

ERROR: (no-return-await) /Users/sechs/Work/vscode-java-debug/src/languageServerPlugin.ts[76, 12]: Unnecessary 'await'.

ERROR: (no-return-await) /Users/sechs/Work/vscode-java-debug/src/utility.ts[59, 12]: Unnecessary 'await'.
ERROR: (no-return-await) /Users/sechs/Work/vscode-java-debug/src/utility.ts[64, 12]: Unnecessary 'await'.
ERROR: (no-return-await) /Users/sechs/Work/vscode-java-debug/src/utility.ts[69, 12]: Unnecessary 'await'.

ERROR: (no-console) /Users/sechs/Work/vscode-java-debug/test/index.ts[20, 9]: Calls to 'console.error' are not allowed.

Please take a look again.

@Eskibear Eskibear merged commit a5407d8 into microsoft:master Aug 20, 2019
@Eskibear Eskibear deleted the pr-update branch August 20, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@testforstephen testforstephen testforstephen approved these changes

@akaroml akaroml akaroml approved these changes

@jdneo jdneo Awaiting requested review from jdneo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eskibear @testforstephen @akaroml