Repository navigation
Add way to disable run and debug code lens provider - #465
Jinbo Wang (testforstephen) merged 5 commits into
Conversation
11b2412 to
b8d479b
Compare
There are cases where it will never work properly, and it is confusing a chunk of my users that attempt to use it, and wonder why it fails Closes microsoft#464
b8d479b to
34245b5
Compare
| }, | ||
| "java.debug.settings.enableRunDebugCodeLens": { | ||
| "type": "boolean", | ||
| "description": "Enable the run and debug code lens providers over main methods", |
There was a problem hiding this comment.
use %template% style of the most recent commit
There was a problem hiding this comment.
Fixed. I used google translate to get the italian translation
| this.lensProvider = vscode.languages.registerCodeLensProvider(JAVA_LANGID, new DebugCodeLensProvider()); | ||
| } | ||
|
|
||
| this.configurationEvent = vscode.workspace.onDidChangeConfiguration((event) => { |
There was a problem hiding this comment.
add type declaration for event parameter.
There was a problem hiding this comment.
Is that the standard in here? There are other places I saw looking around that did not type the parameter, so I wanted to match.
https://github.com/Microsoft/vscode-java-debug/blob/master/src/configurationProvider.ts#L21
There was a problem hiding this comment.
It's better to do that. We need fix that place too.
There was a problem hiding this comment.
Ok. I pushed a fix for this one.
Jinbo Wang (testforstephen)
left a comment
Jinbo Wang (testforstephen)
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution.
| "java.debugger.configuration.enableHotCodeReplace.description": "Enable hot code replace for Java code." | ||
| } No newline at end of file | ||
| "java.debugger.configuration.enableHotCodeReplace.description": "Enable hot code replace for Java code.", | ||
| "java.debugger.configuration.enableRunDebugCodeLens.description": "Enable the run and debug code lens providers over main methods" |
There was a problem hiding this comment.
One tiny comment. Add a dot . at the end.
There was a problem hiding this comment.
Done
There are cases where it will never work properly, and it is confusing a chunk of my users that attempt to use it, and wonder why it fails.
Closes #464