Repository navigation
Change active editor oct icon to file-text instead of clock - #419
Merged
Merged
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Jinbo Wang (testforstephen)
requested review from
Yan Zhang (Eskibear),
Andy Xu(devdiv) (andxu) and
Yaohai Zheng (yaohaizh)
September 11, 2018 01:48
| pickItems[positionForActiveEditor].detail += `, active editor (${path.basename(options[positionForActiveEditor].filePath)})`; | ||
| } else { | ||
| pickItems[positionForActiveEditor].detail = `$(clock) active editor (${path.basename(options[positionForActiveEditor].filePath)})`; | ||
| pickItems[positionForActiveEditor].detail = `$(file-text) active editor (${path.basename(options[positionForActiveEditor].filePath)})`; |
Member
There was a problem hiding this comment.
I don't see any "file-text" in octicons. Is it this one?
Contributor
Author
There was a problem hiding this comment.
vscode doesn't recognize $(file). Refer to vscode source code about the supported list.
https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/ui/octiconLabel/octicons/octicons.less#L94
Yan Zhang (Eskibear)
approved these changes
Sep 11, 2018
Yan Zhang (Eskibear)
left a comment
Yan Zhang (Eskibear)
left a comment
Member
There was a problem hiding this comment.
Note that "file-text" has been renamed to "file" since v7.0.0. See: primer/octicons@4adadb6
Please note that if VS Code updates octicons version, it might cause a small problem.
Yaohai Zheng (yaohaizh)
approved these changes
Sep 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Fix issue #403