Repository navigation
Ignore auto-generated files in test projects. - #384
Merged
Merged
Conversation
Yan Zhang (Eskibear)
requested review from
Rome Li (akaroml),
Andy Xu(devdiv) (andxu),
Jinbo Wang (testforstephen) and
Yaohai Zheng (yaohaizh)
August 29, 2018 02:29
Jinbo Wang (testforstephen)
requested changes
Aug 29, 2018
| # Ignore following generated files to keep SCM clean. | ||
| .gradle/ | ||
| .settings/ | ||
| .project |
Contributor
There was a problem hiding this comment.
some test project is eclipse project itself, how to handle the case?
Member
Author
There was a problem hiding this comment.
Note that this file is under the test project 12, it only takes effect within the folder
Contributor
There was a problem hiding this comment.
please add .idea
Member
Author
There was a problem hiding this comment.
I'm not going to do that in this PR. .idea should be added in the global .gitignore file (if needed).
Actually I don't think we need to add that because this project is not supposed to be open in IntelliJ IDEA.
Jinbo Wang (testforstephen)
approved these changes
Aug 29, 2018
Andy Xu(devdiv) (andxu)
approved these changes
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When developing the extension, the language server somehow is activated and recognizes the gradle projects. It auto generates some files. It's better to ignore them in case of being mistakenly checked in.