Repository navigation
"Learn More" link jumps to the associated troubleshooting paragraph directly - #371
Merged
Merged
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Jinbo Wang (testforstephen)
requested review from
Rome Li (akaroml),
Andy Xu(devdiv) (andxu) and
Yaohai Zheng (yaohaizh)
August 21, 2018 02:21
|
|
||
| ## Failed to resolve classpath: | ||
| ### Reason: | ||
| Below are the common failure reasons. |
Contributor
There was a problem hiding this comment.
In the document, it should avoid using xyz which is not meaningful.
Should use meaningful name such as mainClassName, projectName
Contributor
Author
There was a problem hiding this comment.
Nice suggestion. thanks.
| function handleTroubleshooting(choice: string, message: string, anchor: string): string | undefined { | ||
| if (choice === LEARN_MORE) { | ||
| openLink(TROUBLESHOOTING_LINK); | ||
| const link = anchor ? `${TROUBLESHOOTING_LINK}#${anchor}` : TROUBLESHOOTING_LINK; |
Contributor
There was a problem hiding this comment.
no need for a link variable since it is simple and used only once
Contributor
Author
There was a problem hiding this comment.
fixed.
| export async function showErrorMessageWithTroubleshooting(message: IMessage, ...items: string[]): Promise<string | undefined> { | ||
| const choice = await showErrorMessage(message, ...items, LEARN_MORE); | ||
| return handleTroubleshooting(choice, message.message); | ||
| return handleTroubleshooting(choice, message.message, message.anchor); |
Contributor
There was a problem hiding this comment.
rename IMessage/message to ITroubleShooting/troubleShoot?
Contributor
Author
There was a problem hiding this comment.
fixed.
Andy Xu(devdiv) (andxu)
approved these changes
Aug 22, 2018
Yaohai Zheng (yaohaizh)
approved these changes
Aug 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requirement is from issue #360