Skip to content

auto select current file as the main class if it contains the mainClass. #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andy Xu(devdiv) (andxu) wants to merge 3 commits into from
Closed

auto select current file as the main class if it contains the mainClass. #287

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e6dd04
auto select current file as the main class if it contains the mainClass.
andxu Apr 24, 2018
31c1f1a
remove try catch logic(useless catch)
andxu Apr 25, 2018
9efbbb4
Merge branch 'master' into andy_mainclass_auto
andxu Apr 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/configurationProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,21 @@ export class JavaDebugConfigurationProvider implements vscode.DebugConfiguration
}).sort ((a, b): number => {
return a.label > b.label ? 1 : -1;
});
// try to filter the only class same as the current file, if found one, use this one.
if (vscode.window.activeTextEditor
&& vscode.window.activeTextEditor.document && vscode.window.activeTextEditor.document.fileName) {
const narrowedChoice = pickItems.filter((options) => {
return options && options.item && options.item.filePath &&
(options.item.filePath === vscode.window.activeTextEditor.document.fileName ||
(process.platform === "win32"
&& options.item.filePath.toLowerCase() === vscode.window.activeTextEditor.document.fileName.toLowerCase()));
});

if (narrowedChoice.length === 1) {

@akaroml Rome Li (akaroml) Apr 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of remove items from the list, can we highlight the item that is currently selected from the active document?

@andxu Andy Xu(devdiv) (andxu) Apr 25, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not available in vscode

return narrowedChoice[0].item;
}
}

const selection = pickItems.length > 1 ?
await vscode.window.showQuickPick(pickItems, { placeHolder: "Select main class<project name>" })
: pickItems[0];
Expand Down Expand Up @@ -273,5 +288,6 @@ function convertLogLevel(commonLogLevel: string) {

interface IMainClassOption {
readonly projectName?: string;
readonly filePath?: string;
readonly mainClass: string;
}