Skip to content

only do rebuild for single file - #176

Merged
Xuan Zhou (ansyral) merged 1 commit into
microsoft:masterfrom
ansyral:fixbuild
Nov 28, 2017
Merged

Xuan Zhou (ansyral) merged 1 commit into
microsoft:masterfrom
ansyral:fixbuild

Conversation

@ansyral

Copy link
Copy Markdown
Contributor

Signed-off-by: xuzho xuzho@microsoft.com

  1. rebuild only for single file
  2. fix regression of multi-root
  3. for single file, if its build fails, would ask user to choose whether to proceed. currently, if abort the launch for single file, vscode would pop up an error message "cannot read property openconfigfile of undefined", i've opened an issue to track

Signed-off-by: xuzho <xuzho@microsoft.com>
return vscode.window.withProgress({location: vscode.ProgressLocation.Window}, (p) => {
return new Promise((resolve, reject) => {
p.report({message: "Auto generating configuration..."});
resolveMainClass(folder.uri).then((res: any[]) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case the folder in empty? Single file?

Does the java-debug also should be changed for this changes?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if client only opens a file, the folder is undefined. java-debug has handled this.

@ansyral

Copy link
Copy Markdown
Contributor Author

verified the issue is fixed in vscode insider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants