Skip to content

Fix the issue 146 which cause the petclinic project unable to start. #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andy Xu(devdiv) (andxu) wants to merge 2 commits into from
Closed

Fix the issue 146 which cause the petclinic project unable to start. #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da1eff
Fix the issue 146 which cause the petclinic project unable to start.
andxu Nov 17, 2017
0a137ab
update package lock file and remove useless comment
andxu Nov 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to the "vscode-java-debugger" extension will be documented i
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## 0.3.1 - 2017-11-17
### Fixed
- Fix the unable to start debugging issue[Issue#146](https://github.com/Microsoft/vscode-java-debug/issues/146)

## 0.3.0 - 2017-11-10
### Added
- Support debugging java 9 project. See [Issue#47](https://github.com/Microsoft/vscode-java-debug/issues/47)
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ A lightweight Java Debugger based on [Java Debug Server](https://github.com/Micr
## Requirements
- JDK (version 1.8.0 or later)
- VS Code (version 1.17.0 or later)
- [Language Support for Java by Red Hat](https://marketplace.visualstudio.com/items?itemName=redhat.java) (version 0.13.0 or later)
- [Language Support for Java by Red Hat](https://marketplace.visualstudio.com/items?itemName=redhat.java) (version 0.14.0 or later)

## Install

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "vscode-java-debug",
"displayName": "Debugger for Java",
"description": "A lightweight Java debugger for Visual Studio Code",
"version": "0.3.0",
"version": "0.3.1",

@testforstephen Jinbo Wang (testforstephen) Nov 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version in package-lock.json.

"publisher": "vscjava",
"preview": true,
"aiKey": "67d4461e-ccba-418e-8082-1bd0acfe8516",
Expand Down Expand Up @@ -35,7 +35,7 @@
"main": "./out/src/extension",
"contributes": {
"javaExtensions": [
"./server/com.microsoft.java.debug.plugin-0.3.0.jar"
"./server/com.microsoft.java.debug.plugin-0.3.1.jar"
],
"commands": [],
"debuggers": [
Expand Down
20 changes: 7 additions & 13 deletions src/configurationProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,19 +86,13 @@ export class JavaDebugConfigurationProvider implements vscode.DebugConfiguration
await updateDebugSettings();
}

// Fix issue: https://github.com/Microsoft/vscode-java-debug/issues/146.
// A bug in java launguage support extension causes the compilation task continue to clean and
// generate files after the command returned and the debuggee will report
// "Could not find or load main class" error when it find the required class file is not in the classpath,
// the commented code will be uncommented when java launguage support extension version 0.14.0 release comes out.
// the bug is fixed at https://github.com/redhat-developer/vscode-java/commit/d7cb375874665b826377c072a914623f03362f4d
// try {
// const buildResult = await vscode.commands.executeCommand(commands.JAVA_BUILD_WORKSPACE);
// console.log(buildResult);
// } catch (err) {
// vscode.window.showErrorMessage("Build failed, please fix build error first.");
// return config;
// }
try {

@testforstephen Jinbo Wang (testforstephen) Nov 17, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments.

const buildResult = await vscode.commands.executeCommand(commands.JAVA_BUILD_WORKSPACE);
console.log(buildResult);
} catch (err) {
vscode.window.showErrorMessage("Build failed, please fix build error first.");
return config;
}

if (Object.keys(config).length === 0) { // No launch.json in current workspace.
// check whether it is opened as a folder
Expand Down