Repository navigation
Support java 9 - #124
Merged
Merged
Support java 9#124
Conversation
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Yaohai Zheng (yaohaizh)
suggested changes
Nov 3, 2017
|
|
||
| - `mainClass` (required) - The main class of the program (fully qualified name, e.g. com.xyz.MainClass). | ||
| - `mainClass` (required) - The main class of the program (fully qualified name, e.g. [<mymodule>/]com.xyz.MainClass). | ||
| - `args` - The command line arguments passed to the program. |
Contributor
There was a problem hiding this comment.
Need < > in the module name?
| if (res.length === 0) { | ||
| vscode.window.showErrorMessage( | ||
| "No main class is resolved in the workspace. Please specify the mainClass (e.g. com.xyz.MainClass) in the launch.json."); | ||
| "No main class is resolved in the workspace. Please specify the mainClass " + |
Contributor
There was a problem hiding this comment.
Should be similar from statement below:
"Cannot resolve the modulepaths/classpaths automatically, "
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Xuan Zhou (ansyral)
previously approved these changes
Nov 6, 2017
| ### Launch | ||
|
|
||
| - `mainClass` (required) - The main class of the program (fully qualified name, e.g. com.xyz.MainClass). | ||
| - `mainClass` (required) - The main class of the program (fully qualified name, e.g. [<mymodule>/]com.xyz.MainClass). |
Contributor
There was a problem hiding this comment.
Need remove <, > here?
Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
Yaohai Zheng (yaohaizh)
approved these changes
Nov 6, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
Peer PR on server side:
microsoft/java-debug#90