Remove existing encoding workarounds from client side #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
approved these changes
Nov 19, 2021
Member
|
remember to remove launcher script related code from 1. utility , 2. .bat script from code base |
|
This should be VSC's
|
Contributor
Author
|
@imba-tjd Nice finding, yes, it's |
Contributor
Author
|
The new diagram is as follows.
|
19 tasks
|
The hint message needs to be changed.
另外在Changelog里要一句thanks不过分吧 |
Contributor
Author
|
欢迎提PR来fix这个问题 |
|
搜了一下没搜到 不过我的本意是在已有的0.37的changelog里加一句thanks我for helping addressing the issue的，如果你们觉得不能修改已发布的就算了吧。这个提示信息我就不pr了，我不会ts也没开发过vsc的扩展，还是你们来修 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-java-pack#720
Fixes microsoft/vscode-java-pack#756
Fixes #622
Fixes #623
Fixes #646
Fixes #813
This PR made such changes:
For Windows user, the recommended approach to solve encoding issue is to change the system locale to the target language. Learn more from the Encoding Troubleshooting Guide. https://github.com/microsoft/vscode-java-debug/blob/main/Troubleshooting_encoding.md
