Update telemetry.ts #8243
Update telemetry.ts #8243
Conversation
it looks like in [package.json line 5](https://github.com/microsoft/vscode-cpptools/blob/a62acdb5a52438540c266b409a0ee7f8e64f7a9b/Extension/package.json#L5), we add a suffix, "main", to the version. When we assign customers to target populations for experiments, we were trying to assign customers without any suffix to Public, which resulted in no one being included. Instead, I think we should be checking if the suffix is "main" and assign those customers to Public.
|
Adding @luabud who debugged this issue! |
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
What? In general, the only users who should have the main suffix are internal developers. When we build the public vsix, the main is removed.
|
We're seeing a lot of machines in the Internal population in our experiment, but none in Public. The targetPopulation is assigned here: What I don’t understand is why (userVersion.suffix === "") wouldn’t evaluate to true for Public users. I noticed that we have "version": "1.6.0-main" in package.json... is there a chance the suffix didn't get removed? |
|
I think the problem is that suffix is |
checking for undefined suffix, not just empty string
|
Verified that this change works in local testing |
5 participants
it looks like in package.json line 5, we add a suffix, "main", to the version. When we assign customers to target populations for experiments, we were trying to assign customers without any suffix to Public, which resulted in no one being included. Instead, I think we should be checking if the suffix is "main" and assign those customers to Public.