detect c/c++ source files when running a build a task#8095
Merged
elahehrashedi merged 4 commits intomainfrom Sep 7, 2021
Merged
detect c/c++ source files when running a build a task#8095elahehrashedi merged 4 commits intomainfrom
elahehrashedi merged 4 commits intomainfrom
Conversation
Member
If it works to just put it in the Terminal window, I think that's better than having a separate popup for it. |
michelleangela
approved these changes
Sep 3, 2021
bobbrow
reviewed
Sep 7, 2021
| if (editor && !util.fileIsCOrCppSource(editor.document.fileName)) { | ||
| this.writeEmitter.fire(localize("cannot.build.non.cpp", 'Cannot build and debug because the active file is not a C or C++ source file.') + this.endOfLine); | ||
| this.closeEmitter.fire(-1); | ||
| return Promise.resolve(); |
Member
There was a problem hiding this comment.
This function is async so it should just return; There is no need to call Promise.resolve()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug fix: #7892
Which error message would you prefer to see?
