add ${execpath} and ${pathSeparator}#8077
Merged
elahehrashedi merged 4 commits intomainfrom Aug 31, 2021
Merged
Conversation
bobbrow
changed the title
bobbrow
requested changes
Aug 31, 2021
bobbrow
reviewed
Aug 31, 2021
| } | ||
|
|
||
| result["workspaceFolderBasename"] = this.rootUri ? path.basename(this.rootUri.fsPath) : ""; | ||
| result["execPath"] = process.execPath; |
Member
There was a problem hiding this comment.
Sorry for iterating one comment at a time, but there are a couple more places that need to be updated:
vscode-cpptools/Extension/src/LanguageServer/client.ts
Lines 759 to 761 in 5dcb308
vscode-cpptools/Extension/src/LanguageServer/configurations.ts
Lines 1205 to 1208 in 5dcb308
Contributor
Author
There was a problem hiding this comment.
thank you for finding those.
bobbrow
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug fix: #7753