Skip to content

Fix architecture not supported check.#7924

Merged
sean-mcmanus merged 2 commits intomainfrom
seanmcm/fixArchitectureNotSupported
Aug 6, 2021
Merged

Fix architecture not supported check.#7924
sean-mcmanus merged 2 commits intomainfrom
seanmcm/fixArchitectureNotSupported

Conversation

@sean-mcmanus
Copy link
Contributor

Fixes #7906

@sean-mcmanus sean-mcmanus requested a review from a team August 5, 2021 18:57
@Gengar-lab
Copy link

There is no process.platform !== 'android' in this?

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Aug 6, 2021

There is no process.platform !== 'android' in this?

It's handled by ((process.platform === 'win32' || process.platform === 'darwin') || (arch !== 'arm' && arch !== 'arm64') -- the 1st case evaluates to false and the 2nd check of the arch applies to android or other platforms (in addition to the 1st check arch !== 'x64').

@sean-mcmanus sean-mcmanus merged commit 4d76f74 into main Aug 6, 2021
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixArchitectureNotSupported branch August 6, 2021 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Architecture Arm64 not supported (code-server v3.10.2)

4 participants