Enable localization of walkthrough MD files (provided they are actually HTML)#7894
Merged
Enable localization of walkthrough MD files (provided they are actually HTML)#7894
Conversation
…nto coleng/walkthrough_loc
Colengms
changed the title
sean-mcmanus
approved these changes
Jul 29, 2021
sean-mcmanus
approved these changes
Jul 29, 2021
jogo-
reviewed
Jul 29, 2021
jogo-
reviewed
Jul 29, 2021
jogo-
reviewed
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #7538
Updated translation export and generate scripts to accommodate the file naming and location requirements for localized MD files in a walkthrough. Those requirements are implied here: microsoft/vscode#129461 (comment)
Converted the walkthrough MD files into HTML fragments. Though it should also be possible to author them as HTML files, with HTML and BODY tags intact - it should automatically strip those.
Adds support for
data-loc-hintanddata-loc-hint-<attribute>attributes, to also allow translation hints/comments to be provided within HTML files.