Skip to content

Fix search not finding results in package.nls.json.#7850

Merged
sean-mcmanus merged 1 commit intomainfrom
seanmcm/fixPackageNlsJsonSearch
Jul 20, 2021
Merged

Fix search not finding results in package.nls.json.#7850
sean-mcmanus merged 1 commit intomainfrom
seanmcm/fixPackageNlsJsonSearch

Conversation

@sean-mcmanus
Copy link
Contributor

No description provided.

@sean-mcmanus sean-mcmanus requested review from a team and Colengms July 20, 2021 17:43
@sean-mcmanus
Copy link
Contributor Author

@Colengms There wasn't a reason for **/*.nls.json right? It seems like only **/*.nls.*.json is what we want. It also seems like **/nls.*.json is not used, but it isn't causing any issue so I just kept it.

@Colengms
Copy link
Contributor

@Colengms There wasn't a reason for **/*.nls.json right? It seems like only **/*.nls.*.json is what we want. It also seems like **/nls.*.json is not used, but it isn't causing any issue so I just kept it.

It might be left over from before I was using 'bundles' for localized strings. But, yes, this should be OK to remove.

@sean-mcmanus sean-mcmanus merged commit 948bc0e into main Jul 20, 2021
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixPackageNlsJsonSearch branch July 20, 2021 22:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants