Fix issue with compilerPathIsExplicit not being set properly#7839
Merged
Fix issue with compilerPathIsExplicit not being set properly#7839
Conversation
sean-mcmanus
approved these changes
Jul 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while investigating another issue. If there is no
c_cpp_properties.json,compilerPathIsExplicitwas being set to true when it should have been set to false. When this value is true, a Configuration Warning will be displayed if we need to modify the compiler path for some reason (such as failing to query a compiler and falling back to another compiler). It should be false when using a detected value instead of one that is specified by the user or configuration provider, etc..