Provide separate semantic token fallback scopes for each supported language#7829
Merged
Provide separate semantic token fallback scopes for each supported language#7829
Conversation
sean-mcmanus
requested changes
Jul 14, 2021
Contributor
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
Should the original non-language scopes still exist, such as entity.name.namespace ?
Contributor
Author
I don't think so. It should work properly with the most-qualified name. A theme style is looked up first with the fully qualified scope, and the fallback process removes suffixes. For example, |
sean-mcmanus
approved these changes
Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses: #7773
The root cause of the issue is: microsoft/vscode#128565
Since fixing it in VS Code is not a high priority, this works around the issue by providing separate TextMate fallback scopes for all of our custom semantic tokens as well as standard semantic tokens. When/If the issue is addressed in VS Code, this change can be reverted. It should not cause a problem even if not reverted.