don't squiggle for "cl.exe" or "cl" path#7752
Merged
elahehrashedi merged 3 commits intomainfrom Jun 29, 2021
Merged
Conversation
sean-mcmanus
requested changes
Jun 28, 2021
Contributor
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
Actually, we want any compilerPath than ends with cl.exe or cl to be acceptable, because otherwise, it'll frequently squiggle when the user installs a preview build with a cl.exe version that no longer exists, i.e. we should accept the old path.
sean-mcmanus
approved these changes
Jun 29, 2021
sean-mcmanus
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfix: #7723