Merged
Conversation
Contributor
|
@sean-mcmanus This seems to be related to: #5521 Currently, it's by design that we collapse the entire line containing the closing bracket. Having the fold take as few lines as possible when collapsed (similar to VS) was desired. Also, if we did not include the last line, code immediately preceding a closing brace would not get included in the fold. if (i == 0) {
i = 1
j = 2 }But, not including the last line only when overlapping the start of another folding range, seems OK to me. |
Colengms
approved these changes
Jun 18, 2021
Contributor
Author
|
Ah, I see, it behaves unideally when is used; however, that seems like more desirable behavior than the pre-existing one which hides the else/else if, which is likely very important for the user to see and not be collapsed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5521
@Colengms Is there some problem/bug with this fix and/or a reason this wasn't done initially?