Skip to content

Add SymbolOptions for CppVsDbg#7680

Merged
WardenGnaw merged 2 commits intomainfrom
dev/waan/cppVsDbgSymbolOptions
Jun 11, 2021
Merged

Add SymbolOptions for CppVsDbg#7680
WardenGnaw merged 2 commits intomainfrom
dev/waan/cppVsDbgSymbolOptions

Conversation

@WardenGnaw
Copy link
Member

@WardenGnaw WardenGnaw commented Jun 11, 2021

Add schema to allow customization of how the debugger searches for symbols.

With "searchMicrosoftSymbolServer": true, engine logs show:

<- (E) {"seq":108,"type":"event","event":"progressUpdate","body":{"progressId":"1","message":"Loading symbols for KernelBase.dll","percentage":0}}
<- (E) {"seq":110,"type":"event","event":"progressUpdate","body":{"progressId":"1","message":"Loading symbols for KernelBase.dll from: D:\\Projects\\vcpp\\ConsoleApplication1\\Debug","percentage":0}}
<- (E) {"seq":112,"type":"event","event":"progressUpdate","body":{"progressId":"1","message":"Loading symbols for KernelBase.dll from: C:\\Windows\\SysWOW64\\","percentage":0}}
<- (E) {"seq":114,"type":"event","event":"progressUpdate","body":{"progressId":"1","message":"Loading symbols for KernelBase.dll from: C:\\WINDOWS\\","percentage":0}}
<- (E) {"seq":116,"type":"event","event":"progressUpdate","body":{"progressId":"1","message":"Loading symbols for KernelBase.dll from: C:\\WINDOWS\\symbols\\dll\\","percentage":0}}
<- (E) {"seq":118,"type":"event","event":"progressUpdate","body":{"progressId":"1","message":"Loading symbols for KernelBase.dll from: C:\\WINDOWS\\dll\\","percentage":0}}
<- (E) {"seq":120,"type":"event","event":"progressUpdate","body":{"progressId":"1","message":"Loading symbols for KernelBase.dll from: C:\\Users\\USER\\AppData\\Local\\Temp\\symcache\\wkernelbase.pdb\\cbe4700ef26cd25c4b4801e9e1d2e53e1\\","percentage":0}}

Tested:

"moduleFilter": {
   "mode": "loadAllButExcluded",
   "excludedModules": [ "KernelBase.dll" ]
}

Logs;

<- (E) {"seq":81,"type":"event","event":"progressUpdate","body":{"progressId":"1","message":"Loading symbols for KernelBase.dll","percentage":0}}
<- (E) {"seq":83,"type":"event","event":"output","body":{"category":"console","output":"Loaded 'C:\\Windows\\SysWOW64\\KernelBase.dll'. Symbol loading disabled by Include/Exclude setting.\n"}}

@gregg-miskelly

@WardenGnaw WardenGnaw mentioned this pull request Jun 11, 2021
Merged
gregg-miskelly
gregg-miskelly reviewed Jun 11, 2021
View reviewed changes
gregg-miskelly
gregg-miskelly approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jun 11, 2021

Did you want to get this into 1.5.0-insiders?

@WardenGnaw
Copy link
Member Author

WardenGnaw commented Jun 11, 2021

Did you want to get this into 1.5.0-insiders?

This is just a schema change, so it doesn't really matter. The configuration options are already consumed in the 1.4.1 CppVsdbg debugger.

@WardenGnaw WardenGnaw requested a review from calgagi June 11, 2021 18:51
@WardenGnaw WardenGnaw added this to the 1.5.0-insiders milestone Jun 11, 2021
calgagi
calgagi approved these changes Jun 11, 2021
View reviewed changes
Copy link

@calgagi calgagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WardenGnaw WardenGnaw merged commit 883972a into main Jun 11, 2021
@WardenGnaw WardenGnaw deleted the dev/waan/cppVsDbgSymbolOptions branch August 13, 2021 21:30
@WardenGnaw WardenGnaw mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@calgagi calgagi calgagi approved these changes

@gregg-miskelly gregg-miskelly gregg-miskelly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

debugger Feature Request

Projects

None yet

Milestone

1.5.0-insiders

Development

Successfully merging this pull request may close these issues.

5 participants

@WardenGnaw @sean-mcmanus @jogo- @calgagi @gregg-miskelly