Workaround for webViewPanel.postMessage getting dropped.#7647
Merged
sean-mcmanus merged 2 commits intomainfrom Jun 4, 2021
Merged
Workaround for webViewPanel.postMessage getting dropped.#7647sean-mcmanus merged 2 commits intomainfrom
sean-mcmanus merged 2 commits intomainfrom
Conversation
michelleangela
approved these changes
Jun 4, 2021
jogo-
reviewed
Jun 5, 2021
|
|
||
| // Need to queue another update due to a VS Code regression bug which may drop the initial update. | ||
| // It repros with a higher probability in cases that cause a slower load, such as after | ||
| // switching to a Chinese langauge pack or in the remote scenario. |
Contributor
Author
There was a problem hiding this comment.
Good catch -- I had removed the comment because the code was deleted, but I decided to add it back (with the typo fixed): #7656
sean-mcmanus
added a commit
that referenced
this pull request
Jun 7, 2021
* Workaround for webViewPanel.postMessage getting dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7641 . Workaround for VS Code regression bug microsoft/vscode#125546 .
VS Code can take up to 6 seconds to respond to the postMessage requests (i.e. it could retry around 10 times).