Switch to onDidStartTerminalShellExecution from the obsolete proposed API terminalData* events#13605
Open
fearthecowboy wants to merge 3 commits intomainfrom
Open
Switch to onDidStartTerminalShellExecution from the obsolete proposed API terminalData* events#13605fearthecowboy wants to merge 3 commits intomainfrom
onDidStartTerminalShellExecution from the obsolete proposed API terminalData* events#13605fearthecowboy wants to merge 3 commits intomainfrom
Conversation
…d) API terminalData* events
bobbrow
reviewed
May 13, 2025
bobbrow
reviewed
May 13, 2025
Member
bobbrow
left a comment
bobbrow
left a comment
There was a problem hiding this comment.
Looks good to me. I'll let someone else on the team approve though.
sean-mcmanus
requested changes
May 13, 2025
Contributor
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
Does anyone know how to test this?
|
|
||
| terminalDataHandlingQueue = terminalDataHandlingQueue.finally(() => void handleTerminalOutput(e)); | ||
| for await (const data of e.execution.read()) { | ||
| void handleTerminalOutput(data); |
Contributor
There was a problem hiding this comment.
Should this be void handleTerminalOutput(data).catch(logAndReturn.undefined);?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12575
This stops the use of the proposed deprecated API and uses the newer, released
TerminalShellExecutionsupport.