Fix issues with didOpen synchronization#10442
Merged
Conversation
Contributor
|
There was an error handling pipeline event 5bcf3dfc-91b2-487b-89c8-9b50c1c79cac. |
… it never races with itself.
Contributor
|
There was an error handling pipeline event 2ec4ea3d-9459-438c-849e-6d634acad8ef. |
bobbrow
reviewed
Jan 31, 2023
sean-mcmanus
approved these changes
Jan 31, 2023
michelleangela
approved these changes
Jan 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues with certain messages (semantic token, inlay hints, and code folding) being delivered before we've processed
didOpen.Adds an implicit didOpen for messages that require didOpen to have already occurred.
Updates delayed didOpen processing to use async/await consistently, so processing of didOpen could be more reliably synchronized with.
Always passes
processDelayedDidOpenthroughrequestWhenReadyto avoid the potential race conditions that could occur if multiple callers (i.e. providers) tried to call into it at essentially the same time.Uses
requestWhenReadyin protocolFilter to ensure all async handling in each message handler is included in what is being sequenced.