add ChangeCppPropertiesRequest and remove Notification.#10420
Merged
michelleangela merged 3 commits intomainfrom Jan 27, 2023
Merged
add ChangeCppPropertiesRequest and remove Notification.#10420michelleangela merged 3 commits intomainfrom
michelleangela merged 3 commits intomainfrom
Conversation
browntarik
requested review from
Colengms,
michelleangela and
sean-mcmanus
and removed request for
Colengms and
sean-mcmanus
sean-mcmanus
previously approved these changes
Jan 25, 2023
Colengms
requested changes
Jan 26, 2023
sean-mcmanus
dismissed
their stale review
Waiting for the issue Colen mentioned to be addressed...
sean-mcmanus
approved these changes
Jan 27, 2023
Colengms
approved these changes
Jan 27, 2023
michelleangela
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.