add second prompt for when a compiler needs config#10419
Merged
sean-mcmanus merged 19 commits intomainfrom Feb 1, 2023
Merged
Conversation
browntarik
requested review from
Colengms,
michelleangela and
sean-mcmanus
and removed request for
Colengms and
sean-mcmanus
sean-mcmanus
requested changes
Jan 25, 2023
michelleangela
suggested changes
Jan 26, 2023
sean-mcmanus
requested changes
Jan 26, 2023
…/Microsoft/vscode-cpptools into browntarik/adjustCompilerDialogs
…/Microsoft/vscode-cpptools into browntarik/adjustCompilerDialogs
bobbrow
reviewed
Jan 26, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
michelleangela
previously approved these changes
Jan 30, 2023
…/Microsoft/vscode-cpptools into browntarik/adjustCompilerDialogs
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
sean-mcmanus
requested changes
Jan 31, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
sean-mcmanus
approved these changes
Feb 1, 2023
Contributor
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
I'm approving, but it could use more review/testing.
bobbrow
approved these changes
Feb 1, 2023
Member
bobbrow
left a comment
bobbrow
left a comment
There was a problem hiding this comment.
Please commit the change and let's build the VSIX
michelleangela
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.