Merged
Conversation
bobbrow
reviewed
Dec 22, 2022
…nto coleng/await_in_protocol_filter
sean-mcmanus
requested changes
Jan 18, 2023
sean-mcmanus
approved these changes
Jan 18, 2023
michelleangela
approved these changes
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on discussion related to: #10257
This is a more complete fix for: #10035
Previously worked around by: #10227
This fix is now possible due to an underlying issue in VS Code (actually vscode-languageclient) getting fixed: microsoft/vscode-languageserver-node#1146
Basically, all filters in
protocolFilter.tsare now async, and useawaitto ensure filtered LSP messages are synchronized with other language client operations.