Check for the file version before formatting after CDD.#10210
Merged
sean-mcmanus merged 3 commits intomainfrom Dec 1, 2022
Merged
Check for the file version before formatting after CDD.#10210sean-mcmanus merged 3 commits intomainfrom
sean-mcmanus merged 3 commits intomainfrom
Conversation
sean-mcmanus
commented
Nov 30, 2022
Member
|
Need to resolve with @michelleangela's change which already removed the formatting. |
Contributor
Author
Yeah, I had to submit an empty commit. |
bobbrow
approved these changes
Nov 30, 2022
michelleangela
approved these changes
Dec 1, 2022
sean-mcmanus
added a commit
that referenced
this pull request
Dec 1, 2022
* Check for the file version before formatting after CDD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #10203
Check if the document version is modified before applying the formatting edit.
Also, replaced all the nested "ifs" with early returns since the nesting was getting large.