Skip to content

Add support for selecting a default compiler#10165

Merged
michelleangela merged 53 commits intomainfrom
browntarik/compilerSelection
Jan 25, 2023
Merged

Add support for selecting a default compiler#10165
michelleangela merged 53 commits intomainfrom
browntarik/compilerSelection

Conversation

@browntarik
Copy link
Contributor

@browntarik browntarik commented Nov 17, 2022

Addresses: #10027

@browntarik browntarik marked this pull request as draft November 17, 2022 22:26
@browntarik browntarik changed the title add support for selecting a default compiler Add support for selecting a default compiler Nov 17, 2022
@browntarik browntarik requested a review from Colengms November 17, 2022 22:28
@browntarik browntarik marked this pull request as ready for review November 28, 2022 21:33
caesarpreston
caesarpreston previously approved these changes Jan 21, 2023
michelleangela
michelleangela previously approved these changes Jan 24, 2023
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'm seeing this error when there's no compiler found. Should this be fixed before the checkin?

michelleangela
michelleangela previously approved these changes Jan 25, 2023
@michelleangela
Copy link
Contributor

image

I'm seeing this error when there's no compiler found. Should this be fixed before the checkin?

This can be fixed after check in.

@michelleangela michelleangela merged commit b96737a into main Jan 25, 2023
@michelleangela michelleangela deleted the browntarik/compilerSelection branch January 25, 2023 05:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants