Fixes include "header" issue with multi-root workspaces#10138
Merged
Bernardin-MS merged 9 commits intomainfrom Dec 8, 2022
Merged
Fixes include "header" issue with multi-root workspaces#10138Bernardin-MS merged 9 commits intomainfrom
Bernardin-MS merged 9 commits intomainfrom
Conversation
Colengms
requested changes
Nov 11, 2022
sean-mcmanus
requested changes
Nov 11, 2022
sean-mcmanus
previously approved these changes
Nov 17, 2022
Contributor
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
I'm approving, but I'm not sure if this is what @Colengms was asking for or not so you should wait for his review.
sean-mcmanus
changed the title
Colengms
previously approved these changes
Nov 29, 2022
sean-mcmanus
previously approved these changes
Nov 29, 2022
Bernardin-MS
dismissed stale reviews from sean-mcmanus and Colengms
via
aabfb28
sean-mcmanus
approved these changes
Dec 7, 2022
michelleangela
previously approved these changes
Dec 7, 2022
sean-mcmanus
approved these changes
Dec 7, 2022
michelleangela
approved these changes
Dec 7, 2022
Colengms
approved these changes
Dec 8, 2022
| } | ||
|
|
||
| if (configuration.includePath) { | ||
| configuration.includePath = configuration.includePath.map((path: string) => this.resolvePath(path, this.isWin32)); |
Contributor
There was a problem hiding this comment.
@Colengms @Bernardin-MS This broke recursive includes because ${workspaceFolder}/** has the ** removed. I'm looking into a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #4983