Repository navigation
Engineering - update node version in the build folder - #344080
Ladislau Szomoru (lszomoru) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The Node 24 target conflicts with the locked tree-sitter dependency’s documented C++17 requirement, blocking clean source installs.
1 open issue
What changed in this PR
This PR updates the Node.js target used to compile VS Code’s build-folder dependencies.
Changes:
- Changes the target from Node.js
22.22.1to24.22.1, leaving the other npm settings unchanged.
| File | Description |
|---|---|
build/.npmrc |
Updates the Node.js native-build target. |
Review effort: Balanced
| disturl="https://nodejs.org/dist" | ||
| runtime="node" | ||
| target="22.22.1" | ||
| target="24.22.1" |
|
One or more custom setup steps configured for this repository failed during this Copilot code review run: Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review. Note You can configure setup steps for Copilot code review separately from Copilot cloud agent with a |
No description provided.