Skip to content

Generate dependencies per package build for Debian - #147335

Merged
Raymond Zhao (rzhao271) merged 33 commits into
mainfrom
rzhao271/deb-dependencies
Jul 19, 2022
Merged

Generate dependencies per package build for Debian#147335
Raymond Zhao (rzhao271) merged 33 commits into
mainfrom
rzhao271/deb-dependencies

Conversation

@rzhao271

@rzhao271 Raymond Zhao (rzhao271) commented Apr 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR fixes #13089.

Instead of having a hardcoded list of dependencies, we now generate the list of dependencies for the Debian package on arm64, armhf, and amd64.

TODO before merge:

  • CI tasks below pass (or, the failures are unrelated to this PR)
  • PR is reviewed
  • Package build CI is green
  • Sanity test on a Debian VM and a Ubuntu VM

@rzhao271 Raymond Zhao (rzhao271) added this to the April 2022 milestone Apr 13, 2022
@rzhao271

Raymond Zhao (rzhao271) commented Apr 15, 2022

Copy link
Copy Markdown
Collaborator Author

CI build f9c1be2209 is green

rzhao271
Raymond Zhao (rzhao271) commented Apr 15, 2022
View reviewed changes
Comment thread build/linux/debian/dep-lists.js Outdated
@rzhao271

Raymond Zhao (rzhao271) commented Apr 19, 2022

Copy link
Copy Markdown
Collaborator Author

Debian CI run used to generate the dependencies: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=166357&view=results

@rzhao271
Raymond Zhao (rzhao271) marked this pull request as draft April 21, 2022 19:59
@rzhao271

Raymond Zhao (rzhao271) commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator Author

I've converted this PR to a draft because it turns out Electron isn't supposed to have a static dependency on libgdk-pixbuf-2.0-0, especially considering that that library has slightly different names between different versions of Ubuntu. We need to firstly get Electron to dynamically link that library instead.

@rzhao271 Raymond Zhao (rzhao271) mentioned this pull request May 4, 2022
Merged
5 tasks
@ChaseKnowlden

Chase Knowlden (ChaseKnowlden) commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

Upstream PR is merged.

@ChaseKnowlden

Chase Knowlden (ChaseKnowlden) commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

Can we change this PR to a regular pull request.

@rzhao271

Raymond Zhao (rzhao271) commented Jun 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Remaining steps:

  • Wait for Electron to release a new version with the fix
  • Update VS Code to reference that new version of Electron
  • Regenerate the dependencies and ensure libgdk-pixbuf doesn't show up in the deps list

@deepak1556 Robo (deepak1556) mentioned this pull request Jun 24, 2022
Merged
@rzhao271
Raymond Zhao (rzhao271) marked this pull request as ready for review July 5, 2022 21:15
@rzhao271

Raymond Zhao (rzhao271) commented Jul 6, 2022

Copy link
Copy Markdown
Collaborator Author

The package is sane and there doesn't seem to be a libgdk-pixbuf package now.

Screenshot showing the package dependencies on an Ubuntu VM

deepak1556
Robo (deepak1556) reviewed Jul 7, 2022
View reviewed changes

@deepak1556 Robo (deepak1556) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, couple of style changes

Comment thread build/linux/rpm/dependencies-generator.ts
Comment thread build/linux/debian/install-sysroot.ts Outdated
Comment thread build/linux/debian/dep-lists.ts Outdated
Comment thread build/linux/debian/dep-lists.ts Outdated
Comment thread build/linux/debian/dep-lists.ts Outdated
Comment thread build/linux/debian/dependencies-generator.ts Outdated
Comment thread build/linux/debian/install-sysroot.ts Outdated
Comment thread build/linux/debian/install-sysroot.ts Outdated
Comment thread build/linux/debian/install-sysroot.ts Outdated
Comment thread build/linux/debian/install-sysroot.ts
deepak1556
Robo (deepak1556) reviewed Jul 19, 2022
View reviewed changes
Comment thread build/linux/debian/checkout-shlibdeps.sh Outdated
Comment thread build/linux/debian/dependencies-generator.ts Outdated
@rzhao271

Raymond Zhao (rzhao271) commented Jul 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Custom build CI passed.
I also did sanity testing yesterday and verified that the package can be installed on Ubuntu 16.04 and Debian 9 VMs.

deepak1556
Robo (deepak1556) approved these changes Jul 19, 2022
View reviewed changes

@deepak1556 Robo (deepak1556) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@rzhao271
Raymond Zhao (rzhao271) merged commit 8feb40b into main Jul 19, 2022
@rzhao271
Raymond Zhao (rzhao271) deleted the rzhao271/deb-dependencies branch July 19, 2022 17:43
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deepak1556 Robo (deepak1556) deepak1556 approved these changes

Assignees

@rzhao271 Raymond Zhao (rzhao271)

Labels

None yet

Projects

None yet

Milestone

July 2022

Development

Successfully merging this pull request may close these issues.

Missing dependencies in debian package

3 participants

@rzhao271 @ChaseKnowlden @deepak1556