Fix zoom-out on an image [#131080] - #134706
Conversation
|
|
||
| const settings = getSettings(); | ||
| const isMac = settings.isMac; | ||
| const isMac = settings.isMac || isMacNavigator(); |
There was a problem hiding this comment.
Why isn't settings.isMac on its own enough?
There was a problem hiding this comment.
Matt Bierner (@mjbvz) VS Code outside of Electron also works in the browser, right?
Running in a browser, even on MacOS, settings.isMac will return false. I think we should add browser side checking as well. Besides as I tested, this fixes the zoom out bug in Chrome.
function isMac(): boolean {
if (typeof process === 'undefined') {
return false;
}
return process.platform === 'darwin';
}
It's function body of settings.isMac value.
I assume, process isn't available on the browser side.
There was a problem hiding this comment.
Ok, let's remove isMac then so there's only source of truth here
There was a problem hiding this comment.
Matt Bierner (@mjbvz) Ok, so do you think that we can only stay when checking isMacNavigator and isMac can be thrown out completely?
There was a problem hiding this comment.
Yes, remove settings.isMac to use the new function instead. I believe settings.isMac is only used inside the webview
|
Thanks! This will be in the next insiders build |
2 participants
This PR fixes #131080.