Add setting to control hover position - #127609
Merged
Merged
Conversation
This adds a hover setting to control whether the user wants hovers to appear above or below the relevant line, if there's space. Fixes microsoft#78560
Contributor
Author
|
Any chance of a review of this before it gets conflicted to death? |
|
This is almost certainly not the right place for this comment, but sorry: It seems like an incredibly small and simple change to review and merge! And it seems like such a no-brainer... most (99%+) programmers write their code starting at the top with the first line, not at the bottom with the last line... so covering up stuff you've just written, above where you're currently writing, seems like the wrong thing (to 99%+ of users). |
Member
|
You're right and I'm sorry for being so slow looking at this. Tim Hutt (@Timmmm) thank you for the high quality contribution and apologies for being unresponsive. |
Contributor
Author
|
No worries - thanks for merging it! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a hover setting to control whether the user wants hovers to appear above or below the relevant line, if there's space.
Tested manually, including when the hover is near the bottom of the editor and this option is enabled.
This PR fixes #78560