Use the actual process image instead of module filename to dedup session #19415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, `GetModuleFileNameW` returns exactly the path (or prefix, in case of a DLL) passed to `CreateProcess` casing and all. Since we were using it to generate the uniquing hash for Portable and Unpackaged instances, this meant that `C:\Terminal\wt` and `C:\TeRmInAl\wt` were considered different instances. Whoops. Using `QueryFullProcessImageNameW` instead results in canonicalization. Maybe the kernel does it. I don't know. What I do know is that it works more correctly. Closes #19253
|
Why, you're welcome! |
DHowett
added a commit
that referenced
this pull request
Oct 8, 2025
…ion (#19415) Apparently, `GetModuleFileNameW` returns exactly the path (or prefix, in case of a DLL) passed to `CreateProcess` casing and all. Since we were using it to generate the uniquing hash for Portable and Unpackaged instances, this meant that `C:\Terminal\wt` and `C:\TeRmInAl\wt` were considered different instances. Whoops. Using `QueryFullProcessImageNameW` instead results in canonicalization. Maybe the kernel does it. I don't know. What I do know is that it works more correctly. (`Query...` goes through the kernel, while `GetModule...` goes through the loader. Interesting!) Closes #19253 (cherry picked from commit 9d7ea77) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgfkTus Service-Version: 1.23
DHowett
added a commit
that referenced
this pull request
Oct 8, 2025
…ion (#19415) Apparently, `GetModuleFileNameW` returns exactly the path (or prefix, in case of a DLL) passed to `CreateProcess` casing and all. Since we were using it to generate the uniquing hash for Portable and Unpackaged instances, this meant that `C:\Terminal\wt` and `C:\TeRmInAl\wt` were considered different instances. Whoops. Using `QueryFullProcessImageNameW` instead results in canonicalization. Maybe the kernel does it. I don't know. What I do know is that it works more correctly. (`Query...` goes through the kernel, while `GetModule...` goes through the loader. Interesting!) Closes #19253 (cherry picked from commit 9d7ea77) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgfkTuo Service-Version: 1.24
dongle-the-gadget
pushed a commit
to dongle-the-gadget/terminal
that referenced
this pull request
Oct 9, 2025
…ion (microsoft#19415) Apparently, `GetModuleFileNameW` returns exactly the path (or prefix, in case of a DLL) passed to `CreateProcess` casing and all. Since we were using it to generate the uniquing hash for Portable and Unpackaged instances, this meant that `C:\Terminal\wt` and `C:\TeRmInAl\wt` were considered different instances. Whoops. Using `QueryFullProcessImageNameW` instead results in canonicalization. Maybe the kernel does it. I don't know. What I do know is that it works more correctly. (`Query...` goes through the kernel, while `GetModule...` goes through the loader. Interesting!) Closes microsoft#19253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently,
GetModuleFileNameWreturns exactly the path (or prefix, in case of a DLL) passed toCreateProcesscasing and all. Since we were using it to generate the uniquing hash for Portable and Unpackaged instances, this meant thatC:\Terminal\wtandC:\TeRmInAl\wtwere considered different instances. Whoops.Using
QueryFullProcessImageNameWinstead results in canonicalization. Maybe the kernel does it. I don't know. What I do know is that it works more correctly.(
Query...goes through the kernel, whileGetModule...goes through the loader. Interesting!)Closes #19253