Only do "keys" fixups for non-nested, non-iterable commands #19408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
pushed a commit
that referenced
this pull request
Oct 8, 2025
## Summary of the Pull Request When we introduced action IDs, we separated "commands" from "keybindings", and introduced fixup logic to rewrite the legacy-style command blocks into the new version. However we don't do any ID logic for nested and iterable commands, so make sure we don't inform the loader for fixups in those cases. ## Validation Steps Performed We no longer repeatedly attempt to fixup the settings file when we see a `"keys"` entry in a nested/iterable command block ## PR Checklist - [x] Closes #18736 (cherry picked from commit 04676bd) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgfjxUM Service-Version: 1.23
DHowett
pushed a commit
that referenced
this pull request
Oct 8, 2025
## Summary of the Pull Request When we introduced action IDs, we separated "commands" from "keybindings", and introduced fixup logic to rewrite the legacy-style command blocks into the new version. However we don't do any ID logic for nested and iterable commands, so make sure we don't inform the loader for fixups in those cases. ## Validation Steps Performed We no longer repeatedly attempt to fixup the settings file when we see a `"keys"` entry in a nested/iterable command block ## PR Checklist - [x] Closes #18736 (cherry picked from commit 04676bd) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgfjzjQ Service-Version: 1.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When we introduced action IDs, we separated "commands" from "keybindings", and introduced fixup logic to rewrite the legacy-style command blocks into the new version. However we don't do any ID logic for nested and iterable commands, so make sure we don't inform the loader for fixups in those cases.
Validation Steps Performed
We no longer repeatedly attempt to fixup the settings file when we see a
"keys"entry in a nested/iterable command blockPR Checklist