Skip to content

Move all blink handling into Renderer #19330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Move all blink handling into Renderer #19330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c23430
Move all blink handling into Renderer
lhecker Sep 23, 2025
1b712b2
Fix tests?
lhecker Sep 23, 2025
1c07227
Fix tests
lhecker Sep 24, 2025
0ff1f1f
Merge remote-tracking branch 'origin/main' into dev/lhecker/cursor-bl…
lhecker Oct 14, 2025
7083bc0
Fix off-by-one bugs
lhecker Oct 14, 2025
8214051
Add support for EVENT_CONSOLE_UPDATE_SIMPLE
lhecker Oct 14, 2025
55e3efe
Fix build
lhecker Oct 15, 2025
dfad2d9
Address feedback, Fix broadcast input
lhecker Oct 16, 2025
99c6193
Fix assert
lhecker Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix build
  • Loading branch information
@lhecker
lhecker committed Oct 15, 2025
commit 55e3efebcdfec0e308e7bb5c0c6b75e5dcaf8b6a
4 changes: 2 additions & 2 deletions src/buffer/out/cursor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ ULONG Cursor::GetSize() const noexcept
return _ulSize;
}

void Cursor::SetIsVisible(bool enable)
void Cursor::SetIsVisible(bool enable) noexcept
{
if (_isVisible != enable)
{
Expand All @@ -56,7 +56,7 @@ void Cursor::SetIsVisible(bool enable)
}
}

void Cursor::SetIsBlinking(bool enable)
void Cursor::SetIsBlinking(bool enable) noexcept
{
if (_isBlinking != enable)
{
Expand Down
4 changes: 2 additions & 2 deletions src/buffer/out/cursor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ class Cursor final
til::point GetPosition() const noexcept;
CursorType GetType() const noexcept;

void SetIsVisible(bool enable);
void SetIsBlinking(bool enable);
void SetIsVisible(bool enable) noexcept;
void SetIsBlinking(bool enable) noexcept;
void SetIsDouble(const bool fIsDouble) noexcept;
void SetSize(const ULONG ulSize) noexcept;
void SetStyle(const ULONG ulSize, const CursorType type) noexcept;
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/base/renderer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ namespace Microsoft::Console::Render
static bool s_IsSoftFontChar(const std::wstring_view& v, const size_t firstSoftFontChar, const size_t lastSoftFontChar);

// Base rendering loop
static DWORD s_renderThread(void*) noexcept;
static DWORD WINAPI s_renderThread(void*) noexcept;
DWORD _renderThread() noexcept;
void _waitUntilCanRender() noexcept;

Expand Down
Loading