Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive database sample demonstrating how to use Semantic Kernel with MySQL database for vector storage operations. The sample includes vector search functionality using OpenAI embeddings and shows how to store and retrieve GitHub file information.
Key changes:
- Complete MySQL database sample with Docker setup and vector operations
- Cleanup of reactor-core dependency from semantickernel-api-data and moved to data-jdbc module
- Minor Docker case standardization fix for presidio sample
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/semantickernel-demos/sk-database-sample/* | New complete database sample with Maven project, Docker setup, and vector storage demonstration |
| semantickernel-api-data/pom.xml | Removes reactor-core dependency that was likely moved to appropriate module |
| data/semantickernel-data-jdbc/pom.xml | Adds reactor-core dependency to the JDBC data module where it's actually needed |
| samples/semantickernel-demos/pom.xml | Adds new database sample module to parent POM |
| samples/semantickernel-demos/sk-presidio-sample/sk-presidio-sample-dockerfile | Standardizes Docker FROM statement case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ickernel-demos/sk-database-sample/src/main/java/com/microsoft/semantickernel/GitHubFile.java
Show resolved
Hide resolved
karianna
previously approved these changes
Sep 20, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
karianna
reviewed
Sep 20, 2025
...ickernel-demos/sk-database-sample/src/main/java/com/microsoft/semantickernel/GitHubFile.java
Show resolved
Hide resolved
…com/microsoft/semantickernel/GitHubFile.java
karianna
reviewed
Sep 20, 2025
Member
karianna
left a comment
karianna
left a comment
There was a problem hiding this comment.
Will have to review this properly later on
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.3/apache-maven-3.9.3-bin.zip | ||
| wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar |
Member
There was a problem hiding this comment.
There's a newer wrapper version IIRC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Contribution Checklist