[rush] Add 'variants' feature to Rush - #722
Merged
Pete Gonzalez (octogonz) merged 12 commits intoOct 25, 2018
Merged
Conversation
Member
Author
There was a problem hiding this comment.
I added this to BaseRushAction because a lot of actions needed to touch the Shrinkwrap file. I could try scoping it to exactly the set of actions that need it, I suppose.
Pete Gonzalez (octogonz)
changed the title
Thomas Michon (ThomasMichon)
force-pushed
the
variants
branch
from
October 18, 2018 20:46
1b26797 to
49a4405
Compare
Member
Author
|
I added a configuration option to opt-in to variants, allowing a list of names and descriptions. I also scoped the acceptance of the parameter to only some commands, not all. |
Thomas Michon (ThomasMichon)
force-pushed
the
variants
branch
from
October 18, 2018 20:58
49a4405 to
b307179
Compare
Thomas Michon (ThomasMichon)
force-pushed
the
variants
branch
from
October 22, 2018 19:58
b307179 to
6957cbe
Compare
Thomas Michon (ThomasMichon)
force-pushed
the
variants
branch
4 times, most recently
from
October 23, 2018 21:42
5d98921 to
990e2c2
Compare
Thomas Michon (ThomasMichon)
force-pushed
the
variants
branch
from
October 25, 2018 19:14
a5a776e to
ea67c74
Compare
# Conflicts: # apps/rush-lib/src/logic/InstallManager.ts
Collaborator
|
This was published as Rush 5.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the proposal in issue #721.